Ignasi Marimon-Clos
Ignasi Marimon-Clos
sbt 1.5 has deprecated some old syntax. When bumping the sbt version to 1.5 a handful of syntax warning started appearing. It'd be good to do a bit of a...
#10495 introduced a workaround to prevent a stackoverflow on Jackson potentially causing a DoS (see https://www.playframework.com/security/vulnerability/CVE-2020-26883-JsonParseUncontrolledRecursion). Jackson 2.12 will fix this out of the box. When Play adopts Jackson 2.12...
(from https://github.com/akka/akka/issues/28212#issuecomment-558525124) `NettySevrer` and `AkkaHTTPServer` add a Coordinated Shutdown task that invokes `super.stop()` knowing that the super trait closes the Logger on that call. This should be decoupled and the...
Once https://github.com/playframework/playframework/pull/8406 is merged and documented we could deprecate ApplicationLifecycle's `stopHook`'s in favor of Coordinated Shutdown tasks.
Play allows binding a single port for `http` traffic and a single port for `https`. Each port will serve exactly the same routes. This issue is to track an improvement...
When using Play embedded, users may build an akka cluster. It's an edge case but still possible. It'd be good to document how to setup Coordinated Shutdown considering that `Downing`...
The comment https://github.com/playframework/playframework/pull/8642#issuecomment-425562851 was not implemented on the actual PR (#8642). The PR was on the `2.6.x` branch but the test is specific enough and the underlying pieces have changed...
> By the way, I've caught those by using validateExternalLinks. :-) Oh, this is the play repo. I assumed that task was on the Ci build already. Let's PR separately...
A clean shutdown should stop all Projection workers early (on `service-stop`) instead of trusting they'll be shutdown as part of the cluster shutdown. _Originally posted by @ignasi35 in https://github.com/lagom/lagom/pull/2426#issuecomment-550346553_
While reviewing [proposal to port CircuitBreakersPanel from Lagom to akka/akka](https://github.com/akka/akka/pull/30241/files#diff-18681c8864837c007124c0ac86a82da99b83eea4855c067b2a834d8405ce6751R34) I think I saw a memory leak. Circuit breakers may be added to the panel's `breakers` `ConcurrentHashMap` but are never...