Igor Starikov

Results 187 comments of Igor Starikov

Thank you. I'll try to review this one in a week.

Thank you. There are some comments, need you opinion on them. We'll also need to extend our test suite if it's decided to merge into master.

Cannot see anything wrong in Travis logs. What exactly are those `assertIn` you've mentioned? How do you run the tests?

> I've added some incorrect symbols to first arg of assertIn and all tests still pass. Can't reproduce on master, fails as expected.

> I didn't find a way to test SITE_ID=1 with domain name from SITE_ID=2 Can't quite understand a use case you're to implement. Please reveal the code that didn't budge.

Basically you can point `ROOT_URLCONF` to any module with `urlpatterns` attribute defined, let it be `tests.py`. Take a look at https://github.com/idlesign/django-sitemessage/blob/master/sitemessage/runtests.py#L18 Hope this'll help.

Certainly. There seems nothing that could prevent you from making any number of test views and wiring those to urlpatterns. The other way is not to use test client at...

We'll probably also need a separate branch to play with before merging into master.

Besides that it's semantically incorrect, it bothers?

* django.test.override_settings - is meant to override a project scoped settings. * setUp / tearDown are for unittest, and not a-pytest-way. * I don't know what exactly what behaviour you...