django-siteprefs icon indicating copy to clipboard operation
django-siteprefs copied to clipboard

WIP: Overwrite django.conf

Open jayvdb opened this issue 4 years ago • 4 comments

Demo for https://github.com/idlesign/django-siteprefs/issues/23

Includes Mimic hackery so that the following works

from django.conf import settings as django_settings
from django.http import JsonResponse

def settings(request):
    return JSONResponse({
        'site_name': django_settings.SITE_NAME,
    })

jayvdb avatar May 29 '20 05:05 jayvdb

Coverage Status

Coverage decreased (-1.2%) to 94.737% when pulling 61da050e4ab39fbe3d980bd9eb39018072239402 on jayvdb:overwrite-django-conf into 9cb3026b94a98299d60ccb61baf567b3d0c64a2f on idlesign:master.

coveralls avatar May 29 '20 05:05 coveralls

Ran into another Mimic annoyance - re wants to see a str or a bytes, and fails on Prefproxy as it is neither.

jayvdb avatar May 29 '20 09:05 jayvdb

We'll probably also need a separate branch to play with before merging into master.

idlesign avatar Jun 02 '20 08:06 idlesign

We'll probably also need a separate branch to play with before merging into master.

Sure. I am in no rush for a merge. I have just deployed this branch to my teams QA environment, but it wont get a lot of QA until a few weeks when we go live. I'll get the next push a bit neater so that you could also safely play with it in test beds at your disposal.

jayvdb avatar Jun 05 '20 04:06 jayvdb