Iskren Ivov Chernev

Results 130 comments of Iskren Ivov Chernev

@mongoose700 thanks for working on this! Using `toArray()` seems like a very sensible thing to do. About adding all the additional code about repeated time, I'm less enthusiastic. About the...

@lvhuiru520 can you please also supply unit tests to showcase what exactly should and shouldn't work. Also, how are you supposed to get current-time after the patch.

@surfdude75 I'm completely lost in this PR, can you drop all the generated code and explain what you're trying to achieve?

Somehow this MR includes a bunch of generated files. About this particular issue, it's best to let users decide whether to use Intl or not, check https://github.com/moment/moment-timezone/issues/873#issuecomment-1228473648 So I'd merge...

Latest moment-timezone (0.5.37) has extended range. In the future we'll release on Linux :) check https://github.com/moment/moment-timezone/issues/999#issuecomment-1229214980

That is a weird one. If you use `toISOString()`, then it correctly outputs `-000001`, which can then be correctly parsed. `format()` uses a default format with `YYYY`, that would then...

Yeah, this thing is a no-go. People should strive to make composable libraries, not compose them into one big unmaintainable mess. If moment-timezone users feel like they need `adjust-time`, fine,...

@joemarieandres please check https://github.com/moment/moment-timezone/issues/723

Sorry, we (the moment-timezone team) do the data bundling on release, and we follow IANA's releases (i.e don't invent or tweak the data). Not really sure what you changed in...

Yep, no-go, thanks @gilmoreorless