moment-timezone icon indicating copy to clipboard operation
moment-timezone copied to clipboard

Published 20 hours ago • verified publisher icon moment

Timezone guess utc offset check

Open ccorcos opened this issue 5 years ago • 1 comments

Fixing an issue from https://github.com/moment/moment-timezone/issues/517.

Some background. CST stands for Central Standard Time and Chicago Standard Time. PST stands for Pacific Standard Time and Philippines Standard Time. This causes Intl API to be unreliable in older versions of Chrome and Electron.

ccorcos avatar Apr 24 '19 00:04 ccorcos

CLA assistant check
All committers have signed the CLA.

jsf-clabot avatar Apr 24 '19 00:04 jsf-clabot

Somehow this MR includes a bunch of generated files.

About this particular issue, it's best to let users decide whether to use Intl or not, check https://github.com/moment/moment-timezone/issues/873#issuecomment-1228473648

So I'd merge something that adds an options object to guess, backwards compatible with existing code, that lets users specify Intl or in-house or both. Then we could put a note about buggy Intl and let users decide how to handle it.

ichernev avatar Aug 28 '22 07:08 ichernev