Iskren Ivov Chernev

Results 130 comments of Iskren Ivov Chernev

I guess the `.js` is a bit redundant. In moment.js we try to export `moment` as a name (`moment.js` was also an available package, but is now deprecated). That fixes...

Yeah, my bad. It is a constructor. Most projects that I've worked with try to hide the constructor and instead provide a factory function. It is a simpler interface (users...

I personally find the concat same case version hard to read. But if that would make it more uniform across platforms its fine.

md5-ying the whole IDL makes sense, it has the includes in it, so any change will produce a different hash (which is good). We might share some code once it's...

For some reason this MR is messed up too, not sure why. What is the reason for this, to figure out if a country is valid or not? I'm not...

The issue is that we load `./` for node, which is `./index.js` which loads the data, by design. Here's a patch that fixes it: ```patch diff --git a/moment-timezone-utils.js b/moment-timezone-utils.js index...

@d-adamkiewicz first of all, ignore the `_d` property, as if it doesn't exist. It is not part of the official API and it is not documented. It could be removed,renamed...

Now, I checked version 1.0.0 and it was "vulnerable", but ofc the patch will not apply cleanly. It is a few lines, so you can apply it by hand (after...

@khataev it is now clarified in the documentation: https://github.com/moment/momentjs.com/commit/d0dc7f13dfbb08de1774ab01fdb4590293f558e4 Just a few notes: * in general all APIs work with millisecond-based timestamps (because this is the default in JavaScript Date)...

We need to set an email list, so far people message me for such issues.