pisa
pisa copied to clipboard
icecube
Monte Carlo-based data analysis
Current analysis class is overly complicated with 2k+ SLOCs and nested function calls that I cannot really see through.... Simpler >> Complicated
When storing/retrieving Map and MapSet objects from dictionaries, one might need the `_state_attrs` attribute. There are two inconsistencies: First: https://github.com/IceCubeOpenSource/pisa/blob/14ed3716eeb5c7ca3a78e55555ef2ef5b774b966/pisa/core/map.py#L2066 In all other classes, the slots of the serializable state...
When summing a map that has errors over all of its dimensions with `map.sum()`, the following error occurs: > --------------------------------------------------------------------------- > AttributeError Traceback (most recent call last) > in >...
Test only runs on CPU; if done so with fp64 it succeeds; if fp32, we get ``` $ export PISA_TARGET=cpu ; export PISA_FTYPE=fp32 ; python ~/src/pisa/pisa/stages/osc/prob3numba/numba_osc.py > Traceback (most recent...
Full build log is here for reference: [1_build (3.6).txt](https://github.com/IceCubeOpenSource/pisa/files/4351429/1_build.3.6.txt), which you can see directly [here](https://github.com/IceCubeOpenSource/pisa/pull/585/checks) General issues: - [x] `matplotlib.use(backend)` warnings everywhere (I'll look into this, might not be too...
Look at how we produce pseudodata by looping over the sequence of asimov distributions for each experiment/detector, https://github.com/IceCubeOpenSource/pisa/blob/master/pisa/analysis/hypo_testing.py#L739, vs. how we don't for pseudodata of the "fiducial" hypothesis: https://github.com/IceCubeOpenSource/pisa/blob/master/pisa/analysis/hypo_testing.py#L900 and...
* Compare https://github.com/IceCubeOpenSource/pisa/blob/master/pisa/analysis/analysis.py#L1037 to https://github.com/IceCubeOpenSource/pisa/blob/master/pisa/analysis/analysis.py#L849
To start, need to make it clear the intent behind params vs. instantiation args, etc. (outdated docs addressing this are [here](https://github.com/IceCubeOpenSource/pisa/wiki/pipeline_config_format) in the GitHub wiki)
Modifying a param should modify the events accordingly, but reco.resolutions changes the events in a way that doesn't allow this behavior. Either the resolutions changes should be instantiation args (which...