pisa icon indicating copy to clipboard operation
pisa copied to clipboard

Published 20 hours ago • verified publisher icon icecube

Function called by minimizer is ignoring user-defined prior penalty function

Open thehrh opened this issue 4 years ago • 2 comments

  • Compare https://github.com/IceCubeOpenSource/pisa/blob/master/pisa/analysis/analysis.py#L1037 to https://github.com/IceCubeOpenSource/pisa/blob/master/pisa/analysis/analysis.py#L849

thehrh avatar Mar 16 '20 11:03 thehrh

Looks like this came from @ts4051 and @philippeller here: https://github.com/IceCubeOpenSource/pisa/blame/master/pisa/analysis/analysis.py#L338 so I'm assigning them to this issue

jllanfranchi avatar Mar 16 '20 20:03 jllanfranchi

The option is uncommented in https://github.com/IceCubeOpenSource/fridge/blob/master/analysis/common/analysis/core/oscillations_analysis.py#L816, though I don't know where else it could have been used

thehrh avatar Mar 16 '20 20:03 thehrh

I believe this has been solved by now, as evidenced by https://github.com/icecube/pisa/blob/master/pisa/analysis/analysis.py#L2667.

thehrh avatar Aug 03 '24 19:08 thehrh