pisa icon indicating copy to clipboard operation
pisa copied to clipboard

Two underscores in state attribute of MapSet class

Open atrettin opened this issue 4 years ago • 1 comments

When storing/retrieving Map and MapSet objects from dictionaries, one might need the _state_attrs attribute. There are two inconsistencies:

First:

https://github.com/IceCubeOpenSource/pisa/blob/14ed3716eeb5c7ca3a78e55555ef2ef5b774b966/pisa/core/map.py#L2066

In all other classes, the slots of the serializable state are in the class attribute _state_attrs. Only in MapSet, this begins with two underscores. This makes it impossible to access the attribute.

Second:

https://github.com/IceCubeOpenSource/pisa/blob/14ed3716eeb5c7ca3a78e55555ef2ef5b774b966/pisa/core/map.py#L298

The state attributes listed are not identical to those in the serializable state, because error_hist is missing. Is this intentional? Maybe there is something I am not getting. Is the _state_attrs not supposed to list the keys one expects in a dictionary?

atrettin avatar Sep 22 '20 13:09 atrettin