Ryan C. Gordon

Results 1356 comments of Ryan C. Gordon

There are definitely places we got things wrong (SDL_Render's function naming is pretty inconsistent, for example), but I don't think we need dogma about making all API calls match a...

Spent a little time with https://github.com/trungnt2910/haiku-cross-compiler to see if we could do this without qemu, and haven't quite gotten there yet: - x86_64 built and could compile SDL for Haiku...

> Maybe instead we should spend time moving some of the GitHub workflows to once daily and add this to it? Yes, and that's the plan, over in #6624 ...even...

> and PRs which modify files in relevant platform folders? This is a good idea, too; the Haiku-specific files don't change often.

It feels like there might be more going on here. A small test program that reproduces the issue would be very helpful to verify the problem.

This is in, and sdl2-compat is updated to handle it in https://github.com/libsdl-org/sdl2-compat/commit/8d19a3a46586f7cfa1517ddd04c452a8cea44d4e

(Doh, I didn't build the tests, I'll fix that up shortly.)

> There is potentially an issue dropping this in as a replacement for OS APIs that use size_t. Like this? ```c if (using_sdl) { readfn = SDL_RWread; } else {...

I mean, one being SDLCALL already causes potential problems here...

Thinking more on this, it doesn't _really_ make sense to use an Sint64 here, since you can't read or write more than your address space can hold in a single...