Borislav Stanimirov
Borislav Stanimirov
The warnings you're getting are from the build of the dependency itself. CPM.cmake adds the dependency's targets in your project, so it's built with it just as other targets (the...
I am not against something in the spirit of @anders-wind 's proposal. The name of the option should be `MARK_INCLUDE_DIRS_AS_SYSTEM` or something similar which indicates that we're talking about directories....
I use this: ```cmake CPMAddPackage(gh:ocornut/[email protected]) add_library(imgui STATIC ${imgui_SOURCE_DIR}/imgui.cpp ${imgui_SOURCE_DIR}/imgui_demo.cpp # optionally comment this out ${imgui_SOURCE_DIR}/imgui_draw.cpp ${imgui_SOURCE_DIR}/imgui_widgets.cpp ${imgui_SOURCE_DIR}/imgui_tables.cpp ) target_include_directories(imgui INTERFACE ${imgui_SOURCE_DIR}) target_compile_definitions(imgui PUBLIC -DIMGUI_DISABLE_OBSOLETE_FUNCTIONS) # optional imgui setting set_target_properties(imgui PROPERTIES...
Hi. Thanks for the PR. I like this one. I've been thinking about something along these lines and I'm glad other have too. I'm not sure about this approach though....
First of all, apologies for the late response. I agree that we should be very careful if we ad something like this. The room for error is big and fixing...
I think examples belong in a separate repo (or maybe multiple separate repos?)
@TheLartians I reproduced the issue with @robertmaynard's code and it does get resolved when the policies are set with `PARENT_SCOPE`. I think this is the better solution
It hadn't occurred to me that including `CPM.cmake` from a subdirectory is an actual use case. But in this case, does it make sense to call `set_policies` upon inclusion? It...
"use scoped options" as in `OGG_BUILD_TESTING` should probably be added to the [guidelines](https://github.com/TheLartians/CPM.cmake/wiki/Preparing-projects-for-CPM.cmake)
I think a good idea to proceed would be this: * Create a tag on master (for example "v1.0.0"). This will also lead to a GitHub release, so the code...