CPM.cmake icon indicating copy to clipboard operation
CPM.cmake copied to clipboard

add sfml and sdl examples

Open Yohannfra opened this issue 4 years ago • 6 comments

Yohannfra avatar Sep 28 '21 12:09 Yohannfra

Hey thanks for the example! It can definitely be useful for users checking how to use the sfml and sdl libraries. However it may be hard to test compilation CI as it seems to be missing X11 support. Maybe you could add the examples to the smippets as well?

TheLartians avatar Sep 28 '21 21:09 TheLartians

I didn't see the snippets page. I'll add it !

Yohannfra avatar Sep 28 '21 22:09 Yohannfra

I think examples belong in a separate repo (or maybe multiple separate repos?)

iboB avatar Sep 29 '21 10:09 iboB

It's really cool to have common library as part of unit testing. Because it test real world scenario. Complexity and hidden bugs often hides in there.

OlivierLDff avatar Sep 29 '21 11:09 OlivierLDff

@OlivierLDff yeah, that's why currently all examples included in the examples directory are included in the CI testing suite. This specific case is a bit complex though as it requires an X11 environment, which is unusual for CI.

TheLartians avatar Oct 02 '21 16:10 TheLartians

I'm doing some unit test on gui (using Qt) in github action, here how I am doing:

sudo apt install libxkbcommon-x11-0 libxcb-icccm4 libxcb-image0 libxcb-xinerama0 libxcb-keysyms1 libxcb1 libxcb-render-util0 libxcb-randr0
xvfb-run ctest --build-config "${{ matrix.build_type }}" --progress --verbose

OlivierLDff avatar Oct 03 '21 18:10 OlivierLDff