Islam Sharabash

Results 82 comments of Islam Sharabash

fwiw I found that replacing `media.discordapp.net` with `cdn.discordapp.com` in the url let the download work

I did that at first, but realized I actually wanted the errors in the main process, since that's where I have bugsnag set to catch them. I'm happy for this...

cc @MatthieuLemoine I tried to make the minimal change to make this work, but I think I'd like to do some refactoring later on to make it s.t. each call...

Hit a weird electron crash, so I removed the call to `isDestroyed`: https://github.com/electron/electron/issues/11797

Hey it seems like the crash I was experiencing might be unrelated to this project, doing some more digging now...

Okay - the other crash I was getting was https://github.com/electron/electron/issues/11797 I think this change is still needed to prevent the main process from crashing when the webContents that's setup to...

Started to work on a proof of concept. I think this should work by: 1. Inject a service worker into the site 2. Use something like sw-toolbox to do a...

I have a proof of concept working on my machine using interceptStreamProtocol. Cleaning up the code and then will send a PR :)

I got this mostly working but hit [this bug](https://github.com/electron/electron/issues/14778) in electron. Once that's fixed, this should work. If anyone is interested the code is here: https://github.com/ibash/nativefier/tree/offline_2

My fix for electron should land soon: https://github.com/electron/electron/pull/14887 after that I can go back to hacking on it in https://github.com/ibash/nativefier/tree/offline_2.