electron-push-receiver icon indicating copy to clipboard operation
electron-push-receiver copied to clipboard

Published 20 hours ago • verified publisher icon MatthieuLemoine

Throw errors

Open ibash opened this issue 7 years ago • 2 comments

@MatthieuLemoine I made this change so that we can opt-in to throwing errors. We catch these and send them to bugsnag, so it should help with catching any edge cases in the gcm code.

ibash avatar Feb 08 '18 01:02 ibash

Can't we use NOTIFICATION_SERVICE_ERROR for this ?

MatthieuLemoine avatar Feb 08 '18 08:02 MatthieuLemoine

I did that at first, but realized I actually wanted the errors in the main process, since that's where I have bugsnag set to catch them. I'm happy for this not to be merged into the main project, as it's kind of an odd use case, and I'm mostly doing it to help flush out any bugs with the changes to push-receiver.

FWIW we're rolling the push-receiver changes, so it'll start getting some production testing :)

ibash avatar Feb 08 '18 18:02 ibash