Dan Ibanez
Dan Ibanez
@bartgol probably the most effective way to get this to happen is to put `-Werror` in the compile flags for the nightly tests.
@bartgol yes, thats the plan. I think we should interpret all test failures as a problem, so now the new effort is to fix all the remaining failing tests, or...
The `space-time-stack` tool only measures memory in `Kokkos::View` allocations, and doesn't use `Kokkos::View` itself, so maybe give that a try and see if it helps.
yep, as I commented in #20, the `hwm` tool uses: ``` getrusage(RUSAGE_SELF, &sys_resources); sys_resources.ru_maxrss ``` which only measures CPU memory. Although `space-time-stack` only measures `Kokkos::View` memory, at least it can...
Would an option to not do hidden visibility make any sense? Or would that break Ascent in some major way?
Is it possible to leave this up to the user so that your builds would specify ``` -DCMAKE_CXX_VISIBILITY_PRESET=ON ``` and each user can choose what visibility their whole build uses?
My bad, I meant: ``` -DCMAKE_CXX_VISIBILITY_PRESET=hidden ``` https://cmake.org/cmake/help/latest/prop_tgt/LANG_VISIBILITY_PRESET.html
That works great for me, thank you!
Hang on... I've tried removing the visibility preset commands from all of Ascen't CMakeLists.txt files and I'm still getting warnings like this... let me explore setting our app's visibility to...
Ah nevermind, I was bitten by CMake caches that were still making things hidden. If I remove all the visibility lines from the Ascent CMake and set `-DVTKm_HIDE_PRIVATE_SYMBOLS=OFF` for VTK-m,...