Ian Gilman
Ian Gilman
I've finally had a chance to take a look at this. It's very strange! Looks like it depends on which image is in the viewer. @w5c17 The quick fix is...
It looks like we don't have an event for when the navigator starts to fade. If you're up for adding one and making a PR of it, I can point...
@DougTCooke Thank you for working on this! Apologies for not reviewing it sooner. I'm going to have to play with it a bit to make sure I'm comfortable with the...
I've done some initial testing with this patch, and everything seems in order. It's certainly appealing to clean up all this code, but also scary... do we really not need...
@DougTCooke Thank you for the additional detail. I've been playing with it and it seems good! I'm just a little hesitant since it's a big change to a core feature....
#2785 just landed and caused some conflicts here. That patch is just changing `var` to `const` and `let`, so it should be pretty straightforward to sort out the conflicts.
@DougTCooke Thank you for fixing the merge conflict! @pearcetm Have you had a chance to test this? Do you want @DougTCooke to host the demo somewhere or can you test...
@pearcetm Can you take another look now that the pages have been updated?
Hmm... Looks like we don't have a facility for rotating our overlays. We do rotate the overlays to match the viewport rotation, but we don't have a way to specify...
I believe it needs to happen after every `update-viewport` event (at least for now), so it would be just like the code you have in your comment but with `update-viewport`...