Ian Gilman
Ian Gilman
Looks like this patch is good except for possibly including the data types in doc comments? @Aiosa would you say it's ready to merge? Now that the tests are running...
Great, looking good! I think this is ready to merge. @Aiosa do you agree?
Maybe it should go in the doc comments for DataTypeConvertor? As a side note, weren't we going to change that to DataTypeConverter?
@Aiosa The build from this merge is failing: https://app.travis-ci.com/github/openseadragon/openseadragon/builds/275320513 I restarted it, in case it was bogus, but it failed again. Oddly, the build from the changelog commit afterwards didn't...
@uschmidt83 I'm wondering if you have any thoughts? You've got a bit of experience in this area.
You shouldn't be getting jank. How does the viewer on https://openseadragon.github.io/ perform on your device? You can try others here: https://openseadragon.github.io/examples/in-the-wild/
Your panning functionality seems reasonable. Do you have the built in panning disabled so they're not fighting each other?
Your settings look good to me. But yeah, I guess I would just suggest removing things (like the overlay and any settings) and see if any of it has an...
That all looks good. And you just have the one viewer? It's not being created and destroyed? There is a tile cache. You can take a look at that. It's...