Ian Buss

Results 7 comments of Ian Buss

Have updated the astro-runtime PR to fix the testing on ARM64. So we should be very close to ready (approvals pending) to pull the trigger when safe to do so.

Yes, I resorted to the rather ugly approach of relying on the fact that child tables all have a different number of fields for now, which is just nasty. Going...

Thanks @andvit, you're absolutely right. Will ensure this is fixed and rolled into the next release. We're also missing a unit test for custom serdes. To re-iterate, the fix is...

@maringuu https://github.com/jcrist/msgspec/blob/13a06dd88bcf553bb0497da3b3f0a2a628627ed6/msgspec/__init__.py#L20 `default=None` is the default for `field()`, so this might not be an issue in practice?

@maringuu Yes you're 100% right, I just found that out the hard way. I think I have addressed it in this PR...: https://github.com/koxudaxi/datamodel-code-generator/pull/1942 (specifically in https://github.com/koxudaxi/datamodel-code-generator/pull/1942/commits/ac120c3e441e313eaf2332a2e4e10191316b101f).

> @maringuu Yes you're 100% right, I just found that out the hard way. I think I have addressed it in this PR...: #1942 (specifically in [ac120c3](https://github.com/koxudaxi/datamodel-code-generator/commit/ac120c3e441e313eaf2332a2e4e10191316b101f)). Probable that that...

See what you think of #1942 @maringuu, I think it addresses two of your issues (#1919 and #1920)