astro-cli icon indicating copy to clipboard operation
astro-cli copied to clipboard

Multi arch runtime image support for local dev

Open neel-astro opened this issue 2 years ago • 2 comments

  • [x] I have checked that a similar feature request does not already exist.

✍️ Is your feature request related to a problem? Please describe.

Runtime team is bringing in new multi-arch images, which will allow docker to not need to emulate on ARM machines since new images would be built for both ARM & AMD64. This will enable a faster start-up time for the users during astro dev start. Attaching timings with a new image on M1 mac, timing improved to 34sec as compared to the usual 3-5 minutes:

Screenshot 2022-07-06 at 11 30 14 PM

Related runtime PR: https://github.com/astronomer/astro-runtime/pull/306

🧩 Describe the solution you'd like

  • astro dev commands should be compatible with the new image, and might not require any changes
  • astro deploy for both cloud & software should ensure they cross-compile to AMD64 on ARM-based machines while building & pushing the image to registry

🤔 Describe alternatives you've considered

💡 Additional context

neel-astro avatar Jul 06 '22 18:07 neel-astro

Have updated the astro-runtime PR to fix the testing on ARM64. So we should be very close to ready (approvals pending) to pull the trigger when safe to do so.

ianbuss avatar Jul 15 '22 17:07 ianbuss

To be tested against multi-arch supported runtime image (quay.io/astronomer/astro-runtime-dev:055d4c9a76b327a78f6c4abcc9ed582fa6d6ffff)

neel-astro avatar Aug 03 '22 09:08 neel-astro

Verified with CLI 1.4.0 & m1 Mac

  1. Verified that astro dev commands work as expected with the new image mentioned above.
  2. Verified that astro deploy command also works as expected with the new image mentioned above.

Screenshot 2022-08-10 at 10.38.26 PM.png

Screenshot 2022-08-10 at 10.47.43 PM.png

Screenshot 2022-08-10 at 10.47.16 PM.png

Priyanka13Astro avatar Aug 16 '22 05:08 Priyanka13Astro