Dustan Kasten
Dustan Kasten
@fuelpagan could you rebase master and add a test case for this scenario?
Can you fix the conflict easy enough? I would guess because `dist/react-maskedinput.js` has been modified in this PR, but we’ve removed it in master.
@cybrass onChange event isn’t being fired by the browser or by this library? We should be emulating whatever React would do so the behavior is seamless.
Hey @andrew--r, Two things: 1. Could you add tests demonstrating the new behavior 2. Revert the es6 module -> commonjs change.
#20 is fixed. This is unblocked! :tada: Once we have tests I’d like to get the old Android tests and some of the other open PRs cleaned up.
@dardone any tests are better than no tests! Ideally I want them to be able to run in browserstack or something similar to verify that we get things like oldish...
To follow up on this: > But the value of 999 is rejected by onChange handler so component re-renders with props of 99 again. But the mask does not re-render...
@aesopwolf @hosmelq the `event` object being mutated here with `rawValue` is a React `SyntheticEvent`. React uses event pooling and recycles the event objects passed through handlers. This would cause future...
Bah. I’m mostly wrong. This is mutating the DOM node with an added property. That feels a bit hackish..
My team hasn’t really had to consider this. We consider the [Robustness Principle](https://en.wikipedia.org/wiki/Robustness_principle) to carry a lot of weight in form design. Specifically, `be liberal in what you accept from...