Dustan Kasten comments

Results 60 comments of


                                            Dustan Kasten

style instead of class

True. It will definitely _increase_ time inside react-blessed’s diffing/payload creation because of the additional work, but not necessarily any measurable impact on actual rendering time. I think the note regarding...

style instead of class

Yes! I have been meaning to explore it after I get a bit more familiar with blessed itself. Also, needed to turn on `debug` mode in the blessed constructor and...

Fix the `progressbar` example

Will look into it soon-ish (holidays+travel=eep)

Doesn't work in Mobile Internet Explorer

Browsers really suck. :smile: what version of React were you using? This problem is exacerbated by some churn in ReactDOM’s internal event handling where it is trying to fix and...

Doesn't work in Mobile Internet Explorer

would you be able to test your many variants with 15.2 by chance?

Fix mask value setting on change

what bug or scenario did you reach where this wasn’t working?

Fix mask value setting on change

Can I get a rebase then I’ll land this in a beta release?

Invoke onKeyDown, onBeforeInput and onPaste handlers from props

The two examples you provided are supported by browsers out of the box. `Tab` -> `onBlur` `Enter` - parent form `onSubmit`

Mask doesn't update if value is changed.

can you default the value to be `''` rather than undefined at your call site? Something like: ``` ```

Get the value from the last character to left.

I believe there is a `getRawValue()` that will get you something close to that.