react-maskedinput icon indicating copy to clipboard operation
react-maskedinput copied to clipboard

Published 20 hours ago • verified publisher icon insin

Add tests

Open muffinresearch opened this issue 9 years ago • 4 comments

After #20 it might be nice to stand-up some tests with karma-webpack or similar - this will probably help reduce the maintenance overhead and make dealing with PRs a little easier.

muffinresearch avatar Oct 22 '15 09:10 muffinresearch

#20 is fixed. This is unblocked! :tada:

Once we have tests I’d like to get the old Android tests and some of the other open PRs cleaned up.

iamdustan avatar Mar 09 '16 14:03 iamdustan

Would a PR submitted using mocha be ok?

darrenjennings avatar Mar 19 '16 16:03 darrenjennings

@dardone any tests are better than no tests!

Ideally I want them to be able to run in browserstack or something similar to verify that we get things like oldish Android working and not regressing

If the nwb tool has opinions I would like to follow those for consistency in insin/* repos, but that isn't a hard rule for now.

Thank you for considering taking in this effort.

iamdustan avatar Mar 23 '16 00:03 iamdustan

Sounds good. We use a combination of nightwatch and mocha on a project I've been working on, so I'll just submit my other PR for this project before you guys require tests!

darrenjennings avatar Mar 23 '16 00:03 darrenjennings