iamdanfox

This change was manually made to an internal repo: ```diff -ByteStreams.copy(new FileInputStream(file), os) +try (InputStream is = new FileInputStream(file)) { + ByteStreams.copy(is, os); +} ``` I was kinda expecting this...

FR: help people spot *almost* unused dependencies

2

## What happened? We recently found someone importing all of hadoop just for the Time class. ## What did you want to happen? It would great if we could somehow...

FR: Prefer ImmutableSet.toImmutableSet() over Collectors.toSet() for `public static final` fields

4

## What happened? In an internal library, we a nice public static final field: ```java public static final Set WHITELISTED_HEADERS = ImmutableSet.of( HttpHeaders.ACCEPT, ... ).stream().map(String::toLowerCase).collect(Collectors.toSet()); ``` But it turns out...

baselineUpdateConfig doesn't clean up extra floating files

1

## What happened? Someone had upgraded a very old repo to latest baseline (0.59.0) and ran `./gradlew baselineUpdateConfig` successfully, but was still getting strange formatting results in IntelliJ. Turns out,...

FR: suggest hoisting Pattern.compile to a static field if it's a compile time constant

1

This isn't really an 'error' per se, but it might turn out to be low-hanging fruit for micro-optimization! Example PR: https://github.com/palantir/conjure-java-runtime-api/pull/172

Always check return value of CountDownLatch#await(long, TimeUnit)

3

## What happened Using baseline 0.37.4, I encountered a fun little bug where tests started running even though a server didn't start up: ```java CountDownLatch latch = new CountDownLatch(1); //...

Recommend `open *.ipr` after generating Intellij IDEA projects

5

There are various different ways of importing java projects into intellij, but the only reliable one to get immutables generation working is to use `open *.ipr`

## What happened? There's not really any point renaming vars for a function like this: ```java @Override public void onReset(LoggerContext ctx) {} ```

## What happened? Most internal repos use a remote Gradle Build Cache, so running `./gradlew classes` on a fresh checkout is quite quick HOWEVER, if you run `./gradlew idea` and...

feat(serve): --base-path serves docs from a subpath to match GitHub pages

7

## Before this PR Using a `base-path` in `$docsify` config makes `doscify serve .` unusable for local development - all requests just return 404. ```js window.$docsify = { name: 'my-project',...