iamdanfox
iamdanfox
I'm gonna defer CR here to a current member (e.g. @CRogers perhaps) as I no longer have powers on this repo. One thing to note is that with the new...
Don't think the infra team is gonna build this because it's not a big correctness / safety issue and hasn't come up as something that frequently slows down CR. Happy...
FYI there's also an open issue on upstream error-prone about this: https://github.com/google/error-prone/issues/1304
@henryptung can you check your `gradle.properties` to see which actual formatter is being used here? My guess is that you've got `com.palantir.baseline-format.eclipse=true`. We found several suboptimal cases that the eclipse...
@sergeykad this log line comes from [error-prone itself](https://github.com/google/error-prone/blob/8beaab4aa02e62a1fb8a6f3f6493f39b6196ffa8/check_api/src/main/java/com/google/errorprone/RefactoringCollection.java#L85-L94), and I've seen it be printed out for every single file even if no changes are made. Was there a particular error-prone...
@SerialVelocity would you be able to put up a quick PR for this? I think it could look quite similar to https://github.com/palantir/gradle-baseline/blob/develop/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/DangerousThrowableMessageSafeArg.java
@aioobe would you like to make the PR for this? I think a refaster rule should do the trick, e.g.: - https://github.com/palantir/gradle-baseline/blob/develop/baseline-refaster-rules/src/main/java/com/palantir/baseline/refaster/SortedFirst.java - https://github.com/palantir/gradle-baseline/blob/develop/baseline-refaster-rules/src/test/java/com/palantir/baseline/refaster/SortedFirstTest.java This wouldn't necessarily disallow them as...
@ft0907 as a short-term workaround, wanna use the old-style syntax? ```gradle buildscript { repositories { maven { url "http://palantir.bintray.com/releases" } } dependencies { classpath 'com.palantir.baseline:gradle-baseline-java:1.3.0' } } apply plugin: 'com.palantir.baseline-checkstyle'...
Would like to keep this open - the problem still exists in the wild.
:+1: ah yep. seems like a bit more of an epic that isn't going to be closed by a single PR... i'm also tracking that we need to tweak the...