iamdanfox

FR: ensure users who catch InterruptedException also call `Thread.currentThread().interrupt()`

4

## What happened? It's easy for people to write code like this with no failures: ```java } catch (InterruptedException e) { throw new RuntimeException(e); } ``` _Just_ rethrowing an exception...

checkstyle FR: prefer static imports of Mockito.when

1

## What happened? I was about to make this suggestion in a code review and then thought, _what if there was some gradle plugin which could advise all these nits...

[FR] detect dangerous usage of 'default' branch in switch statements

1

## What happened? People can write switch statements in such a way that when you add an enum variant the compiler doesn't force you to go and fix the usages....

Disallow URL in equals methods (or @Value.Immutable classes)

3

## What happened? @jroitgrund and I just had a wild time with a debugger hooked up to a production service, where it seemed like an `equals` method was returning false...

StrictUnusedVariable false positive on 'record' (with --enable-preview)

2

## What happened? ```java record Coordinate(int x, int y) {} ``` ``` > Task :witchcraft-example:compileJava FAILED /Volumes/git/template-witchcraft/witchcraft-example/src/main/java/com/palantir/witchcraftexample/WitchcraftExampleServer.java:17: error: [StrictUnusedVariable] The field 'y' is never read. record Coordinate(int x, int y)...

com.palantir.baseline-idea should set up groovy test source dirs correctly

4

## What happened? The following snippet is copied and pasted in lots of internal projects: ```gradle idea { module { testSourceDirs += file("src/test/groovy") } } ``` ## What did you...

## What happened? Opening [palantir/assertj-automation](https://github.com/palantir/assertj-automation) in IntelliJ 2019.2 results in failed compilation saying "Invalid target release 11" even though sourceCompatibility = 1.8 is set. ## What did you want to...

## What happened? A bunch of different projects have reported occasional failures of the form: ``` > Task :sls-elasticsearch-sidecar:checkClassUniqueness FAILED Failed to read JarFile sls-elasticsearch-sidecar-shared.jar (project :sls-elasticsearch-sidecar-shared) java.util.zip.ZipException: invalid entry...

## What happened? Baseline pre [2.38.0](https://github.com/palantir/gradle-baseline/releases/tag/2.38.0) is compiled and tested with error-prone 2.3.3. If a project using one of these older baseline versions finds error_prone_annotations 2.3.4 on their compile classpath,...

## What happened? Currently, it is possible for products to accumulate entirely unused classes without any kind of static analysis failing. This recently caused a false positive when we are...