iamdanfox

Results 154 comments of iamdanfox

To be clear, adding an optional field _is not a wire format break_. Your issue is describing a compilation break that users of the `.of` fields might encounter. I like...

I dunno - the whole 'unknown' thing is supposed to make conjure enums _forward compatible_, so that old code can be left running and it shouldn't break if a server...

@fscreene I've tagged 2.0.0-rc2 which includes this functionality, can you echo back when you've got it working happily on one of your repos?

We have received feedback that silently changing defaults causes unnecessary dev pain, so I think the approach would be to roll out an excavator that just opts people into this...

Out of curiosity, is there a particular log line that you wanted to see the params for? (This is happening when you're using a dialogue client inside a gradle plugin...

@leonz I actually recently added a `PerHostClientFactory` so you can turn a list of uris into a list of channels: https://github.com/palantir/dialogue/blob/46dc7d9ce42c8d941a5d1466b2071806f6211589/dialogue-clients/src/main/java/com/palantir/dialogue/clients/DialogueClients.java#L80-L86. Do you think this could work for your use-case?

I like the idea of trying to make dialogue NIO-friendly before we get too locked in. Reading through the `BodyHandlers.ofString()`, it seems that the java client passes data by calling...

I stumbled across this because I actually defined a Conjure type called 'Object' and everything seemed to work until I actually tried to compile the generated java... the problem arose...

@markelliot I think that would be quite a hard fix in java poet, because we'd need to make all these equals methods reference the fully qualified `java.lang.Object` just based on...

I think the only reason it isn't already a `public final` type is because there's a bit of behaviour in the renderPath method ```java @Override public void renderPath(Map params, UrlBuilder...