conjure-java icon indicating copy to clipboard operation
conjure-java copied to clipboard

Published 20 hours ago • verified publisher icon palantir

Make 'RequireNotNullAuthAndBodyParams' enabled by default

Open iamdanfox opened this issue 6 years ago • 4 comments

This feature flag was introduced in https://github.com/palantir/conjure-java/pull/38 as a way of doing a gradual rollout. Once we've validated a few repos can use this successfully, this flag should be removed and the functionality enabled by default.

iamdanfox avatar Jul 30 '18 14:07 iamdanfox

@fscreene I've tagged 2.0.0-rc2 which includes this functionality, can you echo back when you've got it working happily on one of your repos?

iamdanfox avatar Jul 30 '18 14:07 iamdanfox

Will do, planning to get this tried out this week.

fscreene avatar Jul 31 '18 08:07 fscreene

When are we going to do this? Hit a bug related to this where a null auth header was propagate across services, causing the first service to throw 500 instead of 400 (since http error codes are no longer propagated automatically).

Turned on this feature for a bunch of services, but would be nice to get it by default

gm2211 avatar Mar 13 '19 21:03 gm2211

We have received feedback that silently changing defaults causes unnecessary dev pain, so I think the approach would be to roll out an excavator that just opts people into this new feature flag.

Then in a major version we can switch this on by default.

iamdanfox avatar Mar 14 '19 12:03 iamdanfox