hyuraku

Results 8 comments of hyuraku

@Rylan12 > Migrate all casks to use on_{macos_version} blocks instead of if MacOS.version conditionals I guess we need a new issue on https://github.com/Homebrew/homebrew-cask to get the word out to people...

> I think an issue in homebrew/cask would be great, but only once we've started the process and made sure all of its kinks are worked out (clearly from the...

@Rylan12 I have a question about `We need to handle download errors of the formula.json and cask.json files` I couldn't find the code where we download cask.json; should we add...

@carlocab I suggest a new function to return one formula runtime dependencies; how about? ```ruby def all_runtime_dependencies (formula) required_deps = formula.deps.select{|dep| dep.required? } further_deps = required_deps.map{|r_dep| r_dep.to_formula.deps}.flatten.uniq.select{|dep| dep.required? and !required_deps.include?(dep)...

@MikeMcQuaid Would you review this PR again?

@MikeMcQuaid > Still wondering why there's no code sharing/overlap with upgrade? I will share `Upgrade#print_dry_run_dependencies` in https://github.com/Homebrew/brew/blob/master/Library/Homebrew/upgrade.rb#L97. However, I wonder where we move the funcntion.

@MikeMcQuaid Would you review this PR again?

This is not a bug in Octocat but a behavior based on the specification up to the Ruby 2.7 version. Since Ruby 3.0 onwards, a similar warning is not displayed...