brew icon indicating copy to clipboard operation
brew copied to clipboard

Add `--dry-run` option to `cmd#install`

Open hyuraku opened this issue 1 year ago • 3 comments

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew typecheck with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

closes https://github.com/Homebrew/brew/issues/13668

hyuraku avatar Aug 16 '22 12:08 hyuraku

@MikeMcQuaid Would you review this PR again?

hyuraku avatar Aug 22 '22 12:08 hyuraku

@MikeMcQuaid

Still wondering why there's no code sharing/overlap with upgrade?

I will share Upgrade#print_dry_run_dependencies in https://github.com/Homebrew/brew/blob/master/Library/Homebrew/upgrade.rb#L97. However, I wonder where we move the funcntion.

hyuraku avatar Sep 02 '22 12:09 hyuraku

I will share Upgrade#print_dry_run_dependencies in https://github.com/Homebrew/brew/blob/master/Library/Homebrew/upgrade.rb#L97. However, I wonder where we move the funcntion.

If it's used between both upgrade and install: install.rb makes sense to me 👍🏻

MikeMcQuaid avatar Sep 02 '22 13:09 MikeMcQuaid

@MikeMcQuaid Would you review this PR again?

hyuraku avatar Sep 28 '22 12:09 hyuraku