Peter Chen

Results 10 comments of Peter Chen

> Could you please add a quick summary of what problem the PR solves? > I am not extremely familiar with the benchmark, and I have not touched BigWheels for...

> It is a kind of tracker of statistics for an underlying gauge metrics, and you reset it (by clearing history) whenever you want. Is that correct? Addition to Nathan's...

Adding Angela & Ran since they have reviewed #377 .

> Personally though, I find the metrics framework more confusing with these changes, and not sure if the complexity is justified. My preference is keeping it simple and separate, however...

We do have ImGui input handling now, not sure if we want to add virtual keyboard or bluetooth kb/m

We should consider having a `.clang-tidy` so we can automatically check the naming convention. The `pPointer`, `mMember` and `kConstant` stuff still trips me over all the time.

Mark as draft since I'm still need to verified XR builds.

> This is not the right direction to evolve the swapchain design. We need to move towards a path that make sit easier to evolve XR and non-XR independently. There...

Rebased and only kept whatever is still relevent, so marked comments as resolved as they no longer applies.

I'll add a bit more to the resolution mess To obtain the resolution to render: * `Application::GetWindow{Width,Height}()`, use `mSettings.window.{width,height}` * `GetSwapchain()->GetColorImage(i)->GetWidth()` (04_cube), uses image parameter * `GetSwapchain()->GetWidth()` (22_image_filter), uses swapchain...