bigwheels icon indicating copy to clipboard operation
bigwheels copied to clipboard

Published 20 hours ago • verified publisher icon google

Swapchain cleanup.

Open hysw opened this issue 1 year ago • 5 comments

Use common initialization for dx/vk/xr. Remove some dead code.

hysw avatar Jul 27 '23 01:07 hysw

Mark as draft since I'm still need to verified XR builds.

hysw avatar Jul 27 '23 01:07 hysw

This is not the right direction to evolve the swapchain design. We need to move towards a path that make sit easier to evolve XR and non-XR independently. There is also a bunch of changes to idioms that are common to swapchains in general that make it confusing. It seems like the majority of these concepts belong in an app layer that sits over BigWheels.

The swapchain implementations need to keep simple without being convoluted by mixing app level idioms.

chaoticbob avatar Aug 14 '23 19:08 chaoticbob

This is not the right direction to evolve the swapchain design. We need to move towards a path that make sit easier to evolve XR and non-XR independently. There is also a bunch of changes to idioms that are common to swapchains in general that make it confusing. It seems like the majority of these concepts belong in an app layer that sits over BigWheels.

The swapchain implementations need to keep simple without being convoluted by mixing app level idioms.

So making app not directly using swapchain? (e.g. https://github.com/hysw/bigwheels/commit/3931f6c8dbd7a3a002b3a062c9663127f50293dd ) Otherwise I don't see a way to insert command after present call.

hysw avatar Aug 14 '23 21:08 hysw

This is not the right direction to evolve the swapchain design. We need to move towards a path that make sit easier to evolve XR and non-XR independently. There is also a bunch of changes to idioms that are common to swapchains in general that make it confusing. It seems like the majority of these concepts belong in an app layer that sits over BigWheels. The swapchain implementations need to keep simple without being convoluted by mixing app level idioms.

So making app not directly using swapchain? (e.g. hysw@3931f6c ) Otherwise I don't see a way to insert command after present call.

You can keep all of that at an app layer above BigWheels and customize the swapchain implementation by derivation. I don't want the swapchain interface in BW to deviate away from the APIs.

chaoticbob avatar Aug 15 '23 00:08 chaoticbob

Rebased and only kept whatever is still relevent, so marked comments as resolved as they no longer applies.

hysw avatar Jan 10 '24 00:01 hysw