Harrison Chase

Results 367 comments of Harrison Chase

@Jeffwan its a good question whether its huggingface embeddings or FAISS. i like your PR, but im going to add it as an optional parameter probably, both for backwards compatability...

why only use last -2? shouldnt we want to summarize all? we should do this properly. 1. add a validation assertion that if history is passed in, if there are...

> The benefit of this mock up is that we can avoid calling to the external APIs and at the same time make each LLM output more certain (the real...

i also dont think this is neccessary. allowed_tools can be None for a myriad of reasons. if its None we should just ignore

yeah lets add an "other" otherwise looks awesome

making this work with vespa should be a priority i think what makes sense is to add a method to vespa like "retrieve with metadata filter" or something (better named)....

im fine with schema anywhere tbh, no strong preferences yet. probably easy enough to move there later

interesting idea. im not sure this is the right place to put it tbh. i feel like this is probably something that belongs on the tool wrapper

> * Refactor the `TelegramChatLoader` and `FacebookChatLoader` classes by removing the dependency on pandas and simplifying the message filtering process. why is this desirable? presumably, the filtering done by pandas...

> > * Refactor the `TelegramChatLoader` and `FacebookChatLoader` classes by removing the dependency on pandas and simplifying the message filtering process. > > why is this desirable? presumably, the filtering...