Harrison Chase

> As a side note, I'm questioning the need for two distinct class LLMCache, FullLLMCache. Shouldn't we merge both ? yeah - this is due to some ugliness in the...

do you have an example? we also added a pdf loader (https://langchain.readthedocs.io/en/latest/modules/document_loaders/examples/pdf.html#using-pypdf) - does this one work?

good point. you are correct in all your assumptions. i think in order to provide flexiblity for the user, id prefer to do suggestion 1. maybe at the same time,...

@Yongtae723 that sounds good for me for logger, lets just use the default python logger, eg ``` import logging logger = logging.getLogger(__name__) .... logger.warning(..) ```

@Yongtae723 merged it in!

looks great!

thank you :)

what is the full stack trace? what command are you running to generate this?

i would do your development off of branches! rather than master for this commit in particular, ill open up a separate pr to fix it

https://github.com/hwchase17/langchain/pull/1131