Harrison Chase

Results 367 comments of Harrison Chase

> Ok. I'll throw in an example, fix the docstring comment, and push again. > > N00b question: Maybe someone can tell me why the lint / build step keeps...

completely agree it can be useful to have a system message in the prompt, but thats more the role of the prompt itself rather than the chat history

im not sure this makes sense to include in the notebook - what concepts are you trying to understand better? if its chunk overlap i'd prefer an example that uses...

@hrist0stoichev hows this? https://github.com/hwchase17/langchain/pull/4647 this changes it so there won't be any errors on import. we could look into making truly optional, but would take a bit more effort

(if you want to make truly optional, id accept that pr instead)

@agola11 @nfcampos thoughts on adding something like this base chain class? could raise a specific AsyncNotImplementedError or something?

lets make that the default method then! better than breaking

> The idea is "knowledge loader" works with storage that we do not control. Something that can be used as a "tool" (in terms of LangChain). That can be accessed...

> > > > How about splitting it into 3 classes? > > * `formatters`: CSV, PDF, ... > * `controllable sources`: Google Drive, Microsoft Word, Facebook Chat, ... >...