Manuel Kaufmann

I just checked the latest commit with the updates and I feel there are still some things I'd like to discuss and to be reflected in this document: - Discard...

> > Keep the endpoint un-authed and leave the authed version for v2. > > That will be a breaking change, we should decide if we want to have it...

@ericholscher what's your position about 1) implementing the diffing as a background task and requiring hitting the API twice to get the data, or 2) always perform the diffing at...

@agjohnson the research around `sitediff` you've done is great! It does _almost exactly_ what we want to build here. There are really good ideas and thoughts to consider there. I...

I thought more about this. I started thinking about "_build an integration with `sitediff` and use it behind the scenes to get the list of files changed"_. I took a...

Update: instead of using NamedTuples, we want to use dataclasses 🚀

This looks like a good idea 👍🏼 . I would say it's low priority for now, tho.

I don't have the answer here, but it seems those tests are hitting the [`dummy_dashboard_urls`](https://github.com/readthedocs/readthedocs.org/blob/7b7e84c348f493c986cf8e343fd856c3de5f2892/readthedocs/proxito/urls.py#L155) instead of the documentation Proxito urls.

Maybe the order of the definition changed somehow? `/projects/subproject/` should be caught by https://github.com/readthedocs/readthedocs.org/blob/f941fc73b912ab885075f51d3ea6e6e4da7e03b9/readthedocs/proxito/urls.py#L144

Yeap, that's the issue. This diff makes that test to pass again: ```diff diff --git a/readthedocs/proxito/urls.py b/readthedocs/proxito/urls.py index ba465b3bc..2f3d33b8c 100644 --- a/readthedocs/proxito/urls.py +++ b/readthedocs/proxito/urls.py @@ -212,9 +212,10 @@ debug_urls =...