Manuel Kaufmann

Results 1301 comments of Manuel Kaufmann

> Instead, we will be working on a way to override [pre-defined jobs](https://docs.readthedocs.io/en/stable/build-customization.html#extend-the-build-process), like `build.jobs.install`, and support this use case in a more generic way that will allow you to...

Are you able to reproduce this locally?

> but we have `proxy_buffering off;`. This doesn't mean that `proxy_buffer_size` does not make any effect. Its value is always contemplated, but the strategy is different: http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_buffering

> I do wonder if we keep the ability to disable Addons if someone wants, and then we don't inject them at all? I can see some folks wanting that,...

I updated this PR to keep the ability to disable addons on "for Business". We will require to create `AddonsConfig` object for all the projects on Oct 7th. Something like...

> Putting it in the Addons middleware is probably too heavy, He, this was my first option as well; but I revert it because of the same reason. > but...

> I can write a Celery task to be run on that specific date automatically. Hrm... it seems the `crontab` doesn't accept day, month, year... tho.

So, on October 7th we need to do the following things in both platforms (also local development): 1. Mark `Default all past projects to True` on `DISABLE_SPHINX_MANIPULATION` feature flag. 2....

For now... I added a reminder in Slack at least 🙃

I re-reviewed this PR to check that everything was OK, and we are ready to merge it 👍🏼