readthedocs.org icon indicating copy to clipboard operation
readthedocs.org copied to clipboard

Use a named tuple for tags and branches data

Open stsewd opened this issue 4 years ago • 5 comments

We are passing a list of dictionaries with verbose_name and identifier, we should use a data structure for this instead to avoid bugs. We need to make sure that celery can serialize named tuples.

ref https://github.com/readthedocs/readthedocs.org/pull/7548#discussion_r542636920

stsewd avatar Jan 05 '21 16:01 stsewd

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 02 '21 18:06 stale[bot]

Reference: https://github.com/readthedocs/readthedocs.org/blob/b8eb7728c59be744570d9d600634c2cd396cc126/readthedocs/builds/tasks.py#L256-L264

astrojuanlu avatar Sep 02 '21 14:09 astrojuanlu

Hey, I am really interested in this Issue. I'll work on it as my first contribution to the project

vitorsv1 avatar Oct 16 '21 19:10 vitorsv1

Update: instead of using NamedTuples, we want to use dataclasses 🚀

humitos avatar Aug 10 '23 09:08 humitos

Hi! Wow, there is 2 years since last PR referenced to this issue was created. Is it task still in need? I would like to help!

skv0zsneg avatar Mar 08 '25 15:03 skv0zsneg