Steven Hargrove

Results 31 comments of Steven Hargrove

@dmk255 I think this is all - unless there's more req changes.

@benmosher ok i think all concerns mentioned above are resolved, now. No more changes planned from me, unless requested.

@benmosher any update on this? I don't think it's understood that the `packageDir` option is.currently **broken** without this.

@ljharb In your example snippet, I'm assuming `patterns` represents a glob to match against package names?

@dvsekhvalnov I am going to refactor this pr a bit to meet the functionality described in https://github.com/benmosher/eslint-plugin-import/pull/1104#issuecomment-406074658 From there, I think the plan is to merge that functionality (assuming all...

Would like to see this merged, please?

would really like to see an alpine version of this without npm or yarn

@Anderist that's a totally fair point. I ran into this while experimenting with the plugins. I have no need to use them together. I guess I thought it would be...

in a way... This sort of raises the question of if there's enough situations like this that warrant the need for lifecycle hooks for the transforms plugins perform. Like `pre-scope-hoist`...

my thinking is: - package.json linting occurs in no-unused-dependencies rule - no-extraneous-dependencies rule handles the import linting - a tool shared between both of these rules is a good idea,...