docker-node icon indicating copy to clipboard operation
docker-node copied to clipboard

Add Node debian core variant

Open LaurentGoderre opened this issue 10 months ago • 7 comments

Add debian core variant without npm or yarn

  • [x] Documentation
  • [ ] Version change (Update, remove or add more Node.js versions)
  • [x] Variant change (Update, remove or add more variants, or versions of variants)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Other (none of the above)

Checklist

  • [ ] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING.md document.
  • [x] All new and existing tests passed.

LaurentGoderre avatar Apr 02 '24 18:04 LaurentGoderre

Note to reviewer, only check the top commit since the other one is the security update. I rebased on top of it to validate it would work when the base image (the slim variant) didn't already exist.

LaurentGoderre avatar Apr 03 '24 21:04 LaurentGoderre

Do we also need an opinion from @tianon?

PeterDaveHello avatar Apr 06 '24 17:04 PeterDaveHello

would really like to see an alpine version of this without npm or yarn

hulkish avatar Apr 09 '24 21:04 hulkish

"slim" is already an established convention in official images (with some slight variance for whether it's "FROM slim" or a slimmed image itself), but "core" is not, so I wonder if "core" is already established nomenclature in Node.js communities?

Also, I think it's probably worth updating the templating to not copy docker-entrypoint.sh (which is copied from the "donor" image, not from the build context).

tianon avatar Apr 09 '24 23:04 tianon

We are but painted into a corner because slim already contain package manager so we need a different name.

Why not copy the entry point? Do you think it's better to copy from file?

LaurentGoderre avatar Apr 10 '24 13:04 LaurentGoderre

Well, the Dockerfile as written is already copying the entrypoint from the donor image (which is fine, I think), so having it in the build context again is unnecessary and just makes the diff larger without a real purpose. :smile:

tianon avatar Apr 10 '24 17:04 tianon

Fixed

LaurentGoderre avatar Apr 10 '24 20:04 LaurentGoderre