Steven Hargrove
Steven Hargrove
@LinusU I can understand if that's what is decided. Though, personally i view this as a fix.
I suppose on principle alone its always better to play this safe... Basically this could "break" downstreams since all errors were being swallowed, before. Though, i would argue this would...
@evanw thoughts?
@TheLarkInn Sure: here's a rough draft: ## current structure: ```bash ├── webpack-canary/ │ ├── lib/ │ │ ├── generate-install-object/ │ │ │ └── test/ │ │ ├── get-dependency-examples/ │ │ ...
Not sure how to respond, lots of mixed responses here. Im gathering generally that this idea is rejected? The scoped packages thing was an off handed suggestion. I'm not married...
@ljharp one other thing that occurs to me... is it safe for the cache to exist at module level as i currently have it? Are there instances where I should...
@ljharb Ok I think this is ready now. One easy way to see the benefit here, is by running the following command in both `master` and the branch for this...
@benmosher @ljharb This is a fix to what was missed in https://github.com/benmosher/eslint-plugin-import/pull/1085
@benmosher @ljharb So, I think [this test](https://github.com/hulkish/eslint-plugin-import/blob/master/tests/src/rules/no-extraneous-dependencies.js#L257) is actually incorrect. With my fix, this test fails (succeeds where expected to fail). I _think_ that particular test should instead be: ```js...
I've updated this pr to reflect my last comment.