Erqiang Hu

Results 117 comments of Erqiang Hu

@vjcitn The HDO.db now support `select()` interface and we have changed `DO()` to `HDO()`. ![image](https://user-images.githubusercontent.com/48857018/186753437-eeb33b69-b54f-46db-bf69-0edccdbec796.png)

@vjcitn Hi, has this package entered the review process?

@lshep Hi, how is the review progress of this package, do I need to make any changes?

Maybe you should learn more about "Fisher's exact test": https://www.pathwaycommons.org/guide/primers/statistics/fishers_exact_test/

`upsetplot` is a function in package `enrichplot`.

I don't think it's necessary to modify it. (1) When the input order of the genelist changes, the NES and pvalue/p.adjust/qvalues of the enrichment result keep still, except for `rank`...

If the order of input is randomly sorted, the result(rank and leading_edge) will be affected: [test_gsea.pdf](https://github.com/YuLab-SMU/DOSE/files/7666543/test_gsea.pdf)

Your submission will bring hidden dangers, as I mentioned earlier.

@Nelson-Gon “The rank and leading_edge are calculated by the order of the input genelist, so if you want enable GSEA to support input in any order, these code should also...

Use `?groupGO` to get the doc of this function. Since your gene id is gene symbol, you should add the parameter: `keyType = SYMBOL` .