Harsh Deshpande

the correct command mentioned here: https://github.com/ros2/demos/pull/525#issuecomment-863841261

> It's not too obvious why the action type string is prefixed with action/ for ROS2 types, but not for ROS1 types. I followed the same format as for services...

As per https://github.com/ros2/ros1_bridge/pull/256#pullrequestreview-415768662, I have - tested the `action_bridge` in both directions with `Fibonacci`, and tested `dynamic_bridge` for actions in both directions - updated the README with examples for both...

> tried to fix the formatting issues, but I can't seem to keep both `cpplint` and `uncrustify` happy: https://github.com/ros2/ros1_bridge/runs/4800846315?check_suite_focus=true#step:4:988. Similar issue was observed here https://github.com/ament/ament_lint/issues/158 I have suppressed the `cpplint`...

@tgaspar said: > I have not yet investigated the solution but I think the issue resides there. Developers, please let me know if I am barking at the wrong tree...

I solved it for https://github.com/ros2/ros1_bridge/pull/256 in https://github.com/ros2/ros1_bridge/pull/256/commits/b1800c44af17af5b3a86f0e9aad04391a27cf5bf. Please review. It should be applicable for services as well.

I haven't solved this for services but only for actions. This is the mapping rule I have: ``` ros1_package_name: 'actionlib_tutorials' ros1_action_name: 'Fibonacci' ros2_package_name: 'action_tutorials_interfaces' ros2_action_name: 'Fibonacci' feedback_fields_1_to_2: sequence: 'partial_sequence' ```...

I will extend this for services as well and then you could check again.

There is a logical error in my code, which got exposed while doing the mapping for services. I will fix it and push in new commits in https://github.com/ros2/ros1_bridge/pull/256

https://github.com/ros2/ros1_bridge/pull/256/commits/cdb4795f34703ac42a3941e23b9f3ce7c07e2956 should fix it. @iuhilnehc-ynos could you please check it?