Henrique Sato

Results 15 comments of Henrique Sato

@weizhouapache > I agree this setting should by dynamic, and it is better to be a zone-level setting. Since the maximum number of networks per VPC depends on the hypervisor...

> I can understand your code. Your requirement is not clear to me. Can you explain more about the infrastructure? e.g. the hypervisor types, why the max vpc networks are...

@weizhouapache Thanks for your suggestion. I agree that this situation should include VMs and VRs but the `vpc.max.networks` setting should still exist if the user wants to limit the number...

@DaanHoogland I don't think so, as the tests file is already declared in [github actions](https://github.com/apache/cloudstack/blob/main/.github/workflows/ci.yml#L195C1-L195C45).

> > @DaanHoogland I don't think so, as the tests file is already declared in [github actions](https://github.com/apache/cloudstack/blob/main/.github/workflows/ci.yml#L195C1-L195C45). > > My bad, I thought they were in a new file (hastely...

@DaanHoogland @JoaoJandre Maybe we can target it to the 4.18.2. What do you think?

@DaanHoogland I changed the base branch to 4.18. Some unrelated labels to the PR were added. Could you remove them please?

Any other concerns about this one?