cloudstack
cloudstack copied to clipboard
Quota tariff events
Description
While creating, updating or removing a quota tariff there are no events for any of these actions.
To address that, every time a quota tariff is created, updated or removed, a new event is created containing some details of these operations.
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [X] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
I created, updated and removed a quota tariff. Then I accessed the Events tab and all the operations were there.
Codecov Report
Attention: Patch coverage is 15.38462% with 11 lines in your changes are missing coverage. Please review.
Project coverage is 13.17%. Comparing base (
d8cd122) to head (3aea1c9). Report is 13 commits behind head on 4.18.
Additional details and impacted files
@@ Coverage Diff @@
## 4.18 #8030 +/- ##
============================================
+ Coverage 13.16% 13.17% +0.01%
- Complexity 9199 9207 +8
============================================
Files 2724 2724
Lines 258109 258149 +40
Branches 40228 40235 +7
============================================
+ Hits 33970 34003 +33
Misses 219837 219837
- Partials 4302 4309 +7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@blueorangutan package
@blueorangutan package
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7292
@blueorangutan test
@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
@blueorangutan package
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8245
@blueorangutan package
@hsato03 are we targeting 20 with this PR (cc @JoaoJandre )?
@DaanHoogland @JoaoJandre Maybe we can target it to the 4.18.2. What do you think?
@blueorangutan package
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8555
@blueorangutan test
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
@DaanHoogland @JoaoJandre Maybe we can target it to the 4.18.2. What do you think?
@hsato03 sure
@DaanHoogland @JoaoJandre Maybe we can target it to the 4.18.2. What do you think?
You'll have to rebase - force push for that @hsato03 otherwise we are pulling the whole 4.19 release in.
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
@DaanHoogland I changed the base branch to 4.18.
Some unrelated labels to the PR were added. Could you remove them please?
@blueorangutan package
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8632
@blueorangutan test
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian test result (tid-9189) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40247 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8030-t9189-kvm-centos7.zip Smoke tests completed. 110 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|
@hsato03 I think this needs testing but as you guys are the only heavy users of quota, can you find one of your colleagues to verify this, please?