cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Quota tariff events

Open hsato03 opened this issue 2 years ago • 31 comments

Description

While creating, updating or removing a quota tariff there are no events for any of these actions.

To address that, every time a quota tariff is created, updated or removed, a new event is created containing some details of these operations.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [X] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

I created, updated and removed a quota tariff. Then I accessed the Events tab and all the operations were there.

hsato03 avatar Oct 03 '23 19:10 hsato03

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 13.17%. Comparing base (d8cd122) to head (3aea1c9). Report is 13 commits behind head on 4.18.

Files Patch % Lines
...udstack/api/response/QuotaResponseBuilderImpl.java 20.00% 4 Missing :warning:
...pache/cloudstack/quota/dao/QuotaTariffDaoImpl.java 0.00% 2 Missing :warning:
...e/cloudstack/api/command/QuotaTariffCreateCmd.java 0.00% 2 Missing :warning:
...e/cloudstack/api/command/QuotaTariffDeleteCmd.java 0.00% 2 Missing :warning:
...e/cloudstack/api/command/QuotaTariffUpdateCmd.java 50.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               4.18    #8030      +/-   ##
============================================
+ Coverage     13.16%   13.17%   +0.01%     
- Complexity     9199     9207       +8     
============================================
  Files          2724     2724              
  Lines        258109   258149      +40     
  Branches      40228    40235       +7     
============================================
+ Hits          33970    34003      +33     
  Misses       219837   219837              
- Partials       4302     4309       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 04 '23 07:10 codecov[bot]

@blueorangutan package

DaanHoogland avatar Oct 04 '23 07:10 DaanHoogland

@blueorangutan package

DaanHoogland avatar Oct 10 '23 06:10 DaanHoogland

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 10 '23 06:10 blueorangutan

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7292

blueorangutan avatar Oct 10 '23 07:10 blueorangutan

@blueorangutan test

DaanHoogland avatar Oct 10 '23 11:10 DaanHoogland

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Oct 10 '23 11:10 blueorangutan

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Dec 01 '23 13:12 github-actions[bot]

@blueorangutan package

vishesh92 avatar Jan 09 '24 06:01 vishesh92

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jan 09 '24 06:01 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8245

blueorangutan avatar Jan 09 '24 07:01 blueorangutan

@blueorangutan package

DaanHoogland avatar Feb 06 '24 10:02 DaanHoogland

@hsato03 are we targeting 20 with this PR (cc @JoaoJandre )?

DaanHoogland avatar Feb 06 '24 10:02 DaanHoogland

@DaanHoogland @JoaoJandre Maybe we can target it to the 4.18.2. What do you think?

hsato03 avatar Feb 06 '24 18:02 hsato03

@blueorangutan package

vishesh92 avatar Feb 06 '24 18:02 vishesh92

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Feb 06 '24 18:02 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8555

blueorangutan avatar Feb 06 '24 19:02 blueorangutan

@blueorangutan test

vishesh92 avatar Feb 07 '24 07:02 vishesh92

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Feb 08 '24 13:02 github-actions[bot]

@DaanHoogland @JoaoJandre Maybe we can target it to the 4.18.2. What do you think?

@hsato03 sure

JoaoJandre avatar Feb 08 '24 13:02 JoaoJandre

@DaanHoogland @JoaoJandre Maybe we can target it to the 4.18.2. What do you think?

You'll have to rebase - force push for that @hsato03 otherwise we are pulling the whole 4.19 release in.

DaanHoogland avatar Feb 09 '24 15:02 DaanHoogland

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Feb 09 '24 18:02 github-actions[bot]

@DaanHoogland I changed the base branch to 4.18.

Some unrelated labels to the PR were added. Could you remove them please?

hsato03 avatar Feb 09 '24 19:02 hsato03

@blueorangutan package

DaanHoogland avatar Feb 12 '24 14:02 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Feb 12 '24 14:02 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8632

blueorangutan avatar Feb 12 '24 15:02 blueorangutan

@blueorangutan test

DaanHoogland avatar Feb 13 '24 08:02 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Feb 13 '24 08:02 blueorangutan

[SF] Trillian test result (tid-9189) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40247 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8030-t9189-kvm-centos7.zip Smoke tests completed. 110 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Feb 13 '24 20:02 blueorangutan

@hsato03 I think this needs testing but as you guys are the only heavy users of quota, can you find one of your colleagues to verify this, please?

DaanHoogland avatar Feb 14 '24 16:02 DaanHoogland