Hristo Stoychev

Results 9 comments of Hristo Stoychev

There is a big difference between `statement = select(...)` and `statement = "select(...)"` The first one is actually calling `select` and the second one is just a string. You should...

Or maybe make SQLAlchemy an optional dependency? 99% of langchain can be used without it and we are currently at a point where we can't update langchain because we use...

yeah, https://github.com/hwchase17/langchain/pull/4647 looks good enough

Same thing here. I think `Mapped` is from `SQLAlchemy >= 2.0.0` but the current requirement is `SQLAlchemy > 1.3`. I hope the fix remains compatible with `SQLAlchemy > 1.3` and...

[Updating SQLAlchemy from 1.3 to 1.4](https://docs.sqlalchemy.org/en/14/changelog/migration_14.html) is not "easy". It would be much better if `Mapped` is removed and the constraint for `>1.3` is kept instead. I think `Mapped` is...

`slim` only removes `**/*.py[c|o]`, `**/__pycache__*`, and `**/*.dist-info*` by default. The `.so` files are trimmed only, not removed. If you want to remove anything else you can use: ``` slimPatterns: -...

No, it is a 2 step process 1. Remove `.py` files 2. Move `.pyc` files from `__pycache__` to the parent directory. The 2nd step is currently not achievable.

I doubt compiling takes that long in your case. You can try creating an import profile with https://github.com/nschloe/tuna and see where you spend the majority of time.

I added support for this in https://github.com/revdotcom/revai-python-sdk/pull/101 It is released as `2.18.0`