Jan Škrášek

icon indicating a website link https://hrach.dev icon indicating an email [email protected]

icon company rohlik.group icon location Czechia, Brno icon location Android in Rohlik.group • Kotlin and Android • Jetpack Compose • Nextras Orm and PHP

Results 216 comments of Jan Škrášek

Embeddable as part of composite primary key

Actually yes, I wanted to try out querying and add a test for it.

Incorrect parse of SQL file with double semicolon

Could we test & optionally fix this & integrate through https://github.com/nextras/multi-query-parser/?

Design Tokens Update on 2024-06-25

@rusnacok (i get a push notification every day that the job failed because there is one already opened :D)

Condition over table (without `->id`) is not working

Current status: It is not working on the non-main side. The main side works due to the implementation detail that the property is mapped to the actual column (alarm_id) and...

Condition over table (without `->id`) is not working

I am marking it as a feature request.

Condition over table (without `->id`) is not working

testcase: ```php public function testFilterAutomaticallyById(): void { $ean = new Ean(); $ean->code = '1234'; $ean->book = $this->orm->books->getByIdChecked(1); $this->orm->eans->persistAndFlush($ean); $eanId = $ean->id; $this->orm->clear(); $ean = $this->orm->books->findBy(['ean' => $eanId])->fetch(); Assert::notNull($ean); $book =...

Support for NOT LIKE

> I'm sure though, you must have had a reason for not implementing it, so I'm just curious what it was. No reason, pure omission. Practically, it is possible to...

Support for NOT LIKE

I welcome opening PR with `LikeExpression::MODE_NOT_CONTAINS`. Adding another mode for RAW does not make much sense. I welcome opening PR with NotFunction.

Unused return value checker

Could you please share the argumentation behind this? > ```kotlin > foo() ?: return // foo() is considered unused because its value is lost after comparison with null.` > ```...

Unused return value checker

@sandwwraith let me play devil's advocate role, I'm not sure the things I'm arguing for are the best way, but allow me to share a few arguments: - the feature...