Jan Škrášek

Results 216 comments of Jan Škrášek

I've tried to add `requestLayout` into lib, but id didn't help. The issue is the setting margin/request layout happends onMeasure/onApplyInsets callbacks. When I requestLayout later (e.g. in button click listener),...

Ok, here is a testing code, which works on my OnePlus 7 (A10) and doesn't on LG V10 (A6): Source code MainActivity.kt ```kotlin package test.app.insetactivity import android.os.Bundle import androidx.appcompat.app.AppCompatActivity import...

Well, sorry, this was not a "minimal" repro, here is another trial: the same code just with ``` false true ``` still does not work on older LG devices: ![image](https://user-images.githubusercontent.com/284263/73721904-99ec8c80-4725-11ea-8d1f-6cc93633487e.png)

Well, adding such functionality into a constructor isn't good. It also violates SRP. Introducing a "ShuffleMailer" may be the right way.

> Feel a lot like overengineering. Agreed. Maybe the question is if a such unique functionality should be included in the framework. > BTW: FallbackMailer intentionally already violates SRP This...

Well, what is the benefit? I see it pretty problematic, changing the property doesn't close the old connection.

Manual testing is not only about running the test, but also about compilation, which may take few tens of seconds (especially with Gradle [configuration|build] cache-miss). So I usually switch context...

> @JanTvrdik Wanna join us? No, I want to see just the answer to Jan Tvrdik's question ;)

https://en.wikipedia.org/wiki/Week#Week_numbering > In some countries, though, the numbering system is different from the ISO standard. At least six numberings are in use The ISO is probably good compromise, yet the...