mail icon indicating copy to clipboard operation
mail copied to clipboard

SmtpMailer: constructor parameter $options changed to public properties

Open dg opened this issue 9 years ago • 4 comments

dg avatar Jan 13 '16 20:01 dg

Nice :+1:

fprochazka avatar Jan 14 '16 12:01 fprochazka

Well, what is the benefit? I see it pretty problematic, changing the property doesn't close the old connection.

hrach avatar Jan 14 '16 12:01 hrach

@hrach you'll get better error if you pass incorrect config options to the smtp, even without using the DIC extension. But good point.

fprochazka avatar Jan 14 '16 12:01 fprochazka

Why we can't use setters for this? :smiley: I'm not big friend of public properties at all, there's also username/password.

f3l1x avatar Jun 25 '17 09:06 f3l1x