John Howard
John Howard
FWIW we only use Capabilities.KubeVersion.GitVersion now, on master to: * Detect GKE * Detect 1.22+ - this can be removed, we only support 1.22+ now Unfortunately if the recommendation is...
> An option could be to keep the auto-detect based on I think this is functionally equivalent to what we have now, albiet a bit simpler. Later we have `{{...
> The former solution would mean that with tooling where one cannot control `GitVersion` and only `KubeVersion` can be used (and thus the GKE magic does not work), one can...
Removed one of them, but the CNI one is still there. fyi @bleggett since you were looking at auto-detect
Its discussed in https://docs.google.com/document/d/1wsa06GGiq1LEGwhkiPP0FKIZJqdAiue-VeBonWAzAyk/edit as bit. But basically, there was desire to not merge https://github.com/istio/istio/pull/41062 due to the reasons mentioned in the PR. Instead, we should fix the underlying issue...
The main part is the redirection. The main issue is *I hope* it will be mostly replaced by https://github.com/istio/istio/pull/42372 anyways so it may be throw away work... but that isn't...
Another idea is to make the probe not return 503 immediately but wait until ready then give 200. That way we can give long period but show readiness the moment...
fyi you may run into https://github.com/kubernetes/kubernetes/issues/106896 if you are watching the API server. Although I recall there are some cases where it works, just not all - I don't think...