John Howard

Results 1682 comments of John Howard

I see. I worry this usage is extraordinarily niche. Consistent hash AND rewrite AND regex capture... this really feels like something best outside of core of Istio

Maybe you can insert some custom filter that does some manipulation before the hashing runs

New idea and new problem. At some point we will have Istio reading alpha,beta,stable. Most APIs are in all 3. This means we have 3 copies of each proto across...

Ok there are a few areas to tackle: ## CRDs This is the easiest. We can have the crd-gen read a single set of protos. It doesn't matter which one...

@ericvn the doc comments need to be the same across versions I think, so the solution would be to document `v1` for all the YAML examples on all the versions...

@whitneygriffith yep! And we should. We could, I think, even move the .proto files out of versioned folders if we want. Though we will need to keep the .go files...

> Using the newest API in doc examples will mean any user on older versions will have troubles. We could do it once the oldest supported release of Istio is...

Istio 1.0 would work with V1 CRDs because of how Kubernetes CRD versioning works. https://blog.howardjohn.info/posts/crd-versioning/#version-conversion Gateway only breaks things because they remove APIs

for istio.io, `$mode: none` is how to opt-out. So the one without that is the source of truth. warning box is like ``` {{< warning >}} blah {{< /warning >}}...

The sync should only apply to lines after the sync-start line, which is after `$mode`